Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Tr interface in sqlx/contract.go by missing methods #90

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Extend Tr interface in sqlx/contract.go by missing methods #90

merged 2 commits into from
Nov 10, 2023

Conversation

Zeryoshka
Copy link
Contributor

Thank you for the module, I use it in my Graduate Project with sqlx, and it's really helpful for me

I noticed that the trm/sqlx.Tr lacks several methods that exist in sqlx.Tx and sqlx.DB and decided to add them

@Zeryoshka
fix Tr interface in sqlx/contract.go
27f4412 
(add missing methods of sqlx Tx/DB)
maranqz
maranqz reviewed Nov 9, 2023
View reviewed changes
sqlx/contract.go Outdated Show resolved Hide resolved
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 6817558394

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.015%
Totals Coverage Status
Change from base Build 6773691841: 0.0%
Covered Lines: 1461
Relevant Lines: 1554
💛 - Coveralls

@maranqz maranqz merged commit 4c01d68 into avito-tech:main Nov 10, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maranqz maranqz maranqz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zeryoshka @coveralls @maranqz